Fix formatting in issue 610 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teknico
suggested changes
Dec 5, 2016
| ### How the system test works in detail | ||
|
|
||
| The way the test system works is by passing the input IPv4/IPv6 packets (via pre-recorded pcap-files) to the lwAFTR and comparing the expected packet output (pcap-file) to the packet output that the lwAFTR has generated. | ||
| The optional counters file is compared too to the actual counters file obtained after running the test. This is beeing reflected in snabbvmx check syntax: |
There was a problem hiding this comment.
beeing -> being, or even remove it entirely.
|
|
||
| `CONF V4-IN.PCAP V6-IN.PCAP V4-OUT.PCAP V6-OUT.PCAP [COUNTERS.LUA]` | ||
|
|
||
| V4-OUT.PCAP, V6-OUT.PCAP and COUNTERS.LUA are expected output. These output is compared to files stored temporarily in /tmp/endoutv4.pcap, /tmp/endoutv6.pcap and /tmp/counters.lua. These temporal files are the actual output produced by the lwAFTR after running a test. In order for a test to pass, the actual output must match the expected output. So it's not only that the counters file should match, but also the output .pcap files. (read: if a counters.lua file is provided, then it must still match the V4-OUT.PCAP and V6-OUT.PCAP) |
There was a problem hiding this comment.
expected output -> expected outputs
These output is compared -> These outputs are compared
These temporal files -> These temporary files
| - **V6-IN.PCAP** : Incoming IPv6 packets (from b4). | ||
| - **V4-OUT.PCAP** : Outgoing IPv4 packets (to Internet, decapsulated). | ||
| - **V6-OUT.PCAP** : Outgoing IPv6 packets (to b4, encapsulated) | ||
| - **[COUNTERS.LUA]** : Lua file with counter values. Will be regenerated via [-r] param |
There was a problem hiding this comment.
Why adding a blank before colons in the above six lines? It does not look good.
| configuration and binding table. With that information and knowing the error | ||
| report (ping to lwAFTR but it doesn't reply, valid softwire packet doesn't get | ||
| decapsulated, etc), you craft a hand-made packet that meets the testing case. | ||
| If you detected an error in the lwAFTR, the first step is to obtain the configuration file that SnabbVMX was using, as well as a copy of lwAFTR's configuration and binding table. With that information and knowing the error report (ping to lwAFTR but it doesn't reply, valid softwire packet doesn't get decapsulated, etc), you craft a hand-made packet that meets the testing case. |
There was a problem hiding this comment.
I don't like very long lines: they make diffs harder to read. I prefer hard-wrapped lines.
|
|
||
| **Some adoption of config-files is required** | ||
|
|
||
| The advantage of snabbvmx is the dynamic next-hop resolution via Junos. When running the the lwaftr or snabbvmx app standalone, then the next-hop resolution via Junos is missing. The config-files are required to get modified for static next-hop configuration. |
There was a problem hiding this comment.
When running the the lwaftr -> When running the lwaftr
| - lwaftr and snabbvmx configs | ||
| - binding-table | ||
| - input pcaps | ||
| With known input and results, the test can now be added to the scripted end-to-end.sh to be executed with all other tests to ensure snabbvmx behaves as it should. Furthermore, this end-to-end procedure can be ideally used to report issues! |
There was a problem hiding this comment.
to the scripted end-to-end.sh -> to the "end-to-end.sh" script
|
Thanks for the review @teknico . Fixed the issues and amended the commented issues. PTAL. |
teknico
approved these changes
Dec 5, 2016
dpino
pushed a commit
that referenced
this pull request
Dec 8, 2016
dpino
pushed a commit
that referenced
this pull request
Jun 30, 2017
Implement the L7Spy application and "wall spy" command
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
dpino
pushed a commit
that referenced
this pull request
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional patch for fixing formatting in issue snabbco#610 (igalia/snabb).