Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding crc32c for ext3 #1482

Merged
merged 1 commit into from
May 14, 2021
Merged

fix: adding crc32c for ext3 #1482

merged 1 commit into from
May 14, 2021

Conversation

johannbg
Copy link
Collaborator

Noticed that ext3 is still being used in the wild so let's add it to the crc32c list
so downstream does not have to carry a patch for it.

This pull request changes...

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

Noticed that ext3 is still being used in the wild so let's add it to the crc32c list
so downstream does not have to carry a patch for it.
@johannbg johannbg requested review from danimo and haraldh as code owners May 12, 2021 18:54
@github-actions github-actions bot added fs-lib Issues related to the fs-lib module modules Issue tracker for all modules labels May 12, 2021
@haraldh haraldh enabled auto-merge (rebase) May 13, 2021 04:06
@marcosfrm
Copy link
Contributor

Btrfs since 5.5 supports additional hash functions:

# modinfo btrfs
filename:       /lib/modules/5.12.1-arch1-1/kernel/fs/btrfs/btrfs.ko.xz
softdep:        pre: blake2b-256
softdep:        pre: sha256
softdep:        pre: xxhash64
softdep:        pre: crc32c

But the softdeps are there since 5.5

https://github.com/torvalds/linux/blob/v5.5/fs/btrfs/super.c#L2467

hence no need to specify they here right?

@haraldh
Copy link
Collaborator

haraldh commented May 14, 2021

hence no need to specify they here right?

right

@haraldh haraldh disabled auto-merge May 14, 2021 06:18
@haraldh haraldh merged commit 61f4564 into dracutdevs:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs-lib Issues related to the fs-lib module modules Issue tracker for all modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants