Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nvmf): validate_ip_conn #1588

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix(nvmf): validate_ip_conn #1588

merged 1 commit into from
Aug 23, 2021

Conversation

charles-rose
Copy link

@charles-rose charles-rose commented Aug 23, 2021 •
edited
Loading

  • ifname should be the interface on which $traddr can be reached. It currently gets set to "lo", which is incorrect. This patch identifies the correct interface that would be used for the nvme-of-tcp connection.
  • 'ip l show' and 'ip route get' both succeed if interface and route are present. Current 'if' condition (wrongly) produces a warning when the commands succeed. This patch fixes that.

Signed-off-by: Charles Rose [email protected]

This pull request changes...

Changes

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

fix(nvmf): validate_ip_conn
b56fd5f 
Fix how ifname for a given local_address is found.
Fix logic to detect presence of ifname and route.

Signed-off-by: Charles Rose <[email protected]>
@github-actions github-actions bot added modules Issue tracker for all modules nvmf Issues related to the nvmf module labels Aug 23, 2021
@johannbg johannbg enabled auto-merge (rebase) August 23, 2021 18:54
@johannbg johannbg merged commit 655c65e into dracutdevs:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraldh haraldh haraldh approved these changes

@johannbg johannbg johannbg approved these changes

@danimo danimo Awaiting requested review from danimo

Assignees
No one assigned
Labels
modules Issue tracker for all modules nvmf Issues related to the nvmf module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charles-rose @haraldh @johannbg