Nvmf fixes #1989
Merged
Nvmf fixes #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvme-cli 1.x printed the address using spaces as separator, but nvme-cli 2.x prints the address using commas as separator (exact output from sysfs). E.g., output from `cat /sys/class/nvme/nvme0/address`: traddr=nn-0x201700a09890f5bf:pn-0x201900a09890f5bf,host_traddr=nn-0x200000109b579ef5:pn-0x100000109b579ef5 Also, I suppress rd.nvmf.discover= cmdline option if all fields are empty.
The cmdline hook runs before any network interfaces have been brought up. There's no point in trying to validate the connections at this stage.
The module "nvme" is not required for NVMeoF.
did-setup files are meant to indicate that an interface setup was successful. Don't do it here.
The "finished" initqueue is for testing if everything is alright, not for triggering any actions.
The command line may contain several rd.nvmf.discover options. The "fc,auto" option should take precedence.
"exit" should never be executed in dracut hooks, because the hooks are sourced by the main script.
This way we can set "rd.neednet" and have it seen by parse-ip-options.sh
If multiple ibft interfaces exist, set_ifname() may reuse the same name (usually "ibft0"), because it's usually called cmdline time, when no interfaces exist in sysfs yet. Remember the number used set and don't use it again.
rd.nonvmf=0 is a double negation, and wrong. Fix it.
This is currently always the case for NBFT records. We can do this now, as we run before parse-ip-options.sh
This code would add brackets twice. Fix it.
github-actions
bot
added
modules
|
@aafeijoo-suse for information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of minor (but important) changes for NVMeoF boot. Re-spin of the previous PR.
Changes
Antonio Alvarez Feijoo (1):
fix(nvmf): nvme list-subsys prints the address using commas as separator
Martin Wilck (12):
fix(nvmf): don't try to validate network connections in cmdline hook
fix(nvmf): no need to load the nvme module
fix(nvmf): don't create did-setup file
fix(nvmf): don't use "finished" queue for autoconnect
fix(nvmf): make sure "rd.nvmf.discover=fc,auto" takes precedence
fix(nvmf): avoid calling "exit" in a cmdline hook
fix(nvmf): run cmdline hook before parse-ip-opts.sh
fix(network): don't use same ifname multiple times
fix(man): dracut.cmdline(7): correct syntax for rd.nonvmf
feat(nvmf): set rd.neednet=1 if tcp records encountered
fix(network): avoid double brackets around IPv6 address
fix(man): dracut.cmdline.7: clarify "rd.nvmf.discover=fc,auto"
Checklist