Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade to actions/checkout@v3 #2012

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

LaszloGombos
Copy link
Collaborator

It resolves the following warning:
Please update the following actions to use Node.js 16: actions/checkout

It resolves the following warning:
Please update the following actions to use Node.js 16: actions/checkout
@github-actions github-actions bot added the github Issues related to .github label Oct 22, 2022
@LaszloGombos LaszloGombos removed the github Issues related to .github label Oct 22, 2022
Copy link
Collaborator

@johannbg johannbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannbg
Copy link
Collaborator

johannbg commented Oct 23, 2022

Maybe we should have dependabot handle this CI task for us in the future ( or implement it now and see it working )

  1. https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

@iammattcoleman
Copy link
Contributor

@johannbg Is it possible to configure dependabot to not upgrade some tests? In order to get the manual tests working in the Gentoo container, I had to revert to actions/checkout@v1 in this commit:
ef9ccd5

This is due to version v2+ of the runner using a hardcoded path for an externally-provided node binary, but the provided binary not being compatible with Gentoo:
actions/runner#2115

@johannbg
Copy link
Collaborator

@iammattcoleman it has allow/ignore: see [1] not sure if it works thou but honestly if gentoo is becoming too much trouble than it's worth and a security risk then we simply drop it and focus on something that costs less and makes our lives easier.

  1. https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow

@LaszloGombos LaszloGombos marked this pull request as draft October 23, 2022 22:46
@LaszloGombos
Copy link
Collaborator Author

Marked as draft in favor of testing #2016 .

@LaszloGombos LaszloGombos changed the title ci: upgrade to actions/checkout@v3 WIP: ci: upgrade to actions/checkout@v3 Oct 28, 2022
@LaszloGombos
Copy link
Collaborator Author

Closing to take it out from active PR list. Will reopen if it becomes necessary.

@LaszloGombos LaszloGombos changed the title WIP: ci: upgrade to actions/checkout@v3 ci: upgrade to actions/checkout@v3 Nov 7, 2022
@LaszloGombos
Copy link
Collaborator Author

Reopening for review

@LaszloGombos LaszloGombos reopened this Nov 7, 2022
@LaszloGombos LaszloGombos marked this pull request as ready for review November 7, 2022 20:47
@github-actions github-actions bot added the github Issues related to .github label Nov 7, 2022
@johannbg
Copy link
Collaborator

johannbg commented Nov 8, 2022

Let's merge this and close the other one

@LaszloGombos
Copy link
Collaborator Author

@aafeijoo-suse Would you be able to help with the review of this PR ?

@aafeijoo-suse
Copy link
Member

@aafeijoo-suse Would you be able to help with the review of this PR ?

I don't know how I can help review this change, I'm not an expert on GitHub proprietary stuff and most of the time it just shows issues after the merge.

@LaszloGombos
Copy link
Collaborator Author

LaszloGombos commented Nov 11, 2022

and most of the time it just shows issues after the merge.

This is a fair statement. Please note:

So the decision really is try to land or wait until it will be broken for sure..

@aafeijoo-suse aafeijoo-suse merged commit 60c4b2f into dracutdevs:master Nov 11, 2022
@LaszloGombos LaszloGombos deleted the ci_234 branch November 11, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Issues related to .github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants