-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade to actions/checkout@v3 #2012
Conversation
It resolves the following warning: Please update the following actions to use Node.js 16: actions/checkout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe we should have dependabot handle this CI task for us in the future ( or implement it now and see it working ) |
@johannbg Is it possible to configure dependabot to not upgrade some tests? In order to get the manual tests working in the Gentoo container, I had to revert to actions/checkout@v1 in this commit: This is due to version v2+ of the runner using a hardcoded path for an externally-provided node binary, but the provided binary not being compatible with Gentoo: |
@iammattcoleman it has allow/ignore: see [1] not sure if it works thou but honestly if gentoo is becoming too much trouble than it's worth and a security risk then we simply drop it and focus on something that costs less and makes our lives easier. |
Marked as draft in favor of testing #2016 . |
Closing to take it out from active PR list. Will reopen if it becomes necessary. |
Reopening for review |
Let's merge this and close the other one |
@aafeijoo-suse Would you be able to help with the review of this PR ? |
I don't know how I can help review this change, I'm not an expert on GitHub proprietary stuff and most of the time it just shows issues after the merge. |
This is a fair statement. Please note:
So the decision really is try to land or wait until it will be broken for sure.. |
It resolves the following warning:
Please update the following actions to use Node.js 16: actions/checkout