-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] trunk from WordPress:trunk #1974
base: trunk
Are you sure you want to change the base?
Conversation
…rver` methods. This resolves a WPCS warning: {{{ Variable "$errorString" is not in valid snake_case format, try "$error_string" }}} Follow-up to [5054]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59672 602fd350-edb4-49c9-b593-d223f7449a82
…lows. The benefit of this is that when PRs are made to make changes to a reusable workflow, the references doesn't need to be updated to point to the fork in order for the changed workflow to run. A `npm run grunt replace:workflow-references-local-to-remote` command has also been introduced in order to convert these local references back to remote ones. This command can be used to switch release branches over to using remote workflows, as they are currently, so they continue to benefit from workflow changes in trunk without the need for continual backporting to all the branches. Props desrosj, johnbillion Fixes #62416 git-svn-id: https://develop.svn.wordpress.org/trunk@59673 602fd350-edb4-49c9-b593-d223f7449a82
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @audrasjb602fd350-edb4-49c9-b593-d223f7449a82, @desrosj602fd350-edb4-49c9-b593-d223f7449a82. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
… per `Walker_Nav_Menu` instance rather than for every nav menu item. The `start_el()` method in `Walker_Nav_Menu` was calling `get_privacy_policy_url()` for every menu item when building menus. This resulted in redundant queries, particularly for menus with many items. This obtains the `get_privacy_policy_url()` value in the constructor for reuse in the `start_el()` method to improve performance. Redundant code to construct the privacy policy page is also refactored into the `set_up()` method during tests. Props arzola, swissspidy, westonruter, mukesh27. Fixes #62818. git-svn-id: https://develop.svn.wordpress.org/trunk@59674 602fd350-edb4-49c9-b593-d223f7449a82
This changeset updates the old list tables for themes and theme installation to remove `title` attributes or replace them with a more acessible implementation: - Removes `title` attributes from `span` elements - Replaces `title` with `aria-label` for links whose visible text starts with the same word, consistently with links on the "Add Plugins" screen - Reuses the `$preview_title` variable to keep ARIA labels consistent for both Preview links Follow-up to [22439], [27548], [31513], [32991], [50804], [53414]. Props karlgroves, sabernhardt, audrasjb, alh0319. Fixes #62834. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59675 602fd350-edb4-49c9-b593-d223f7449a82
…dgets sidebar list. This is part of an effort to reduce `title` attribute usage in WordPress Admin. This changeset updates the Customizer Widgets sidebar list to show sidebar name and description (as these informations may benefit to everyone), and remove the `title` attribute. Follow-up to [22439], [27548], [31513], [32991], [50804], [53414], [59675]. Props karlgroves, sabernhardt, mukesh27, joedolson. Fixes #62836. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59676 602fd350-edb4-49c9-b593-d223f7449a82
…ory Description. This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process. Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts. Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860. Fixes #12056. git-svn-id: https://develop.svn.wordpress.org/trunk@59677 602fd350-edb4-49c9-b593-d223f7449a82
… be included. This changeset restricts direct access call in `/wp-admin` and its sub directories. Follow-up to [11768]. Props deepakrohilla. See #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59678 602fd350-edb4-49c9-b593-d223f7449a82
…Actions workflows files. This includes removing use of dangerous inline GitHub Actions expressions, preventing word splitting, further tightening permissions, and generally improving many aspects of the workflows. This also introduces a new workflow that runs Actionlint to detect incorrect and insecure code and configuration in workflow files. Props johnbillion, swissspidy, flixos90, desrosj. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59679 602fd350-edb4-49c9-b593-d223f7449a82
…er` methods. This resolves a WPCS warning: {{{ Variable "$thisEnclosure" is not in valid snake_case format, try "$this_enclosure" }}} Follow-up to [16824], [19848]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59680 602fd350-edb4-49c9-b593-d223f7449a82
The JSON string set as an output for the Slack message payload needs to be one line to prevent causing errors. This ensures `jq` returns a compact JSON string. Follow up to [59679]. Props johnbillion. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59681 602fd350-edb4-49c9-b593-d223f7449a82
This updates `@playwright/test` to the latest version, currently `1.49.1`. In older branches using Playwright, the E2E and Performance workflows have recently started failing. This is due to changes in the GitHub Actions runner images. Updating Playwright ensures more modern dependency trees are used when installing browsers for testing and fixes the issue. Props swissspidy. See #62843. git-svn-id: https://develop.svn.wordpress.org/trunk@59682 602fd350-edb4-49c9-b593-d223f7449a82
…g it to the "Failed Workflow" workflow. Follow-up to [59679]. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59687 602fd350-edb4-49c9-b593-d223f7449a82
…nly be included. This changeset restricts direct access call in `/wp-includes` and its sub directories. Follow-up to [11768], [59678]. Props deepakrohilla. Fixes #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59688 602fd350-edb4-49c9-b593-d223f7449a82
…a single post object. The `wp-singular` class includes a `wp` prefix to avoid conflicts with existing classes. This changeset also updates the `Tests_Post_GetBodyClass` PHPUnit test to include the new CSS class. Props danielpataki, peterwilsoncc, swissspidy, johnbillion, eceleste, poena, audrasjb, raj198, shailu25. Fixes #35164. git-svn-id: https://develop.svn.wordpress.org/trunk@59689 602fd350-edb4-49c9-b593-d223f7449a82
This changeset deletes the arrow that is typically added next to WordPress admin menu items that have submenus. The `.wp-menu-arrow` element is no longer visible since the WP 3.8 redesign, but the HTML and CSS remained. With this changeset, the HTML generating the arrow is removed, and the corresponding CSS styling is deleted. Props helen, azaozz, jbkkd, pbearne, flixos90. Fixes #26960. git-svn-id: https://develop.svn.wordpress.org/trunk@59690 602fd350-edb4-49c9-b593-d223f7449a82
This changeset clarifies the purpose of these functions and make the documentation more accurate and flexible. Instead of referring to the "date the post was written," the functions and filter descriptions now refer to the "date of the post." This change accommodates scenarios where the displayed date might not strictly correspond to the writing date (e.g. scheduled posts, backdated posts, or content where the "date" represents something other than creation). Props casiepa, audrasjb, SergeyBiryukov, Rarst, helen, azouamauriac, pbearne. Fixes #51289. git-svn-id: https://develop.svn.wordpress.org/trunk@59691 602fd350-edb4-49c9-b593-d223f7449a82
…t_post_time()`. This aims to avoid confusion with `the_date()` and `get_the_date()`. Includes synchronizing the description for `the_weekday()` and `the_weekday_date()`, which have very similar functionality, except that the latter will only output the weekday if the current post's weekday is different from the previous one output. Follow-up to [59691]. See #51289. git-svn-id: https://develop.svn.wordpress.org/trunk@59692 602fd350-edb4-49c9-b593-d223f7449a82
… run within the Slack notifications workflow. Prior to r59679 this value was echoed to GitHub output which meant that its surrounding double quotes lost their significance. Now this value is used directly in the job output it needs to be treated as a plain string. This concludes the conclusion confusion. See #82221 git-svn-id: https://develop.svn.wordpress.org/trunk@59693 602fd350-edb4-49c9-b593-d223f7449a82
Remove the option "Disable the visual editor when writing" from the user profile if it is currently false. If enabled, the option will stay available until disabled. This was blocked due to issues with tab order and focusability in the classic editor environment until [59188]. Props mark-k, SergeyBiryukov, joedolson, pento, iseulde, chriscct7, afercia, prasadkarmalkar, rcreators, jamieblomerus. Fixes #34681. git-svn-id: https://develop.svn.wordpress.org/trunk@59695 602fd350-edb4-49c9-b593-d223f7449a82
Rename the 'Text' tab of the classic editor to 'Code', mimicking the labels used in the block editor: "Visual editor" and "Code editor". Update code comment and Help documentation to reference the editor using the new label. Props lukecavanagh, ctienshi, travel_girl, audrasjb, sabernhardt, joedolson, rseigel, mark-k, sergeybiryukov, presskopp, giuriani, afercia, knutsp, audrasjb, sukhendu2002. Fixes #38061. git-svn-id: https://develop.svn.wordpress.org/trunk@59696 602fd350-edb4-49c9-b593-d223f7449a82
…hods. This resolves a WPCS warning: {{{ Variable "$ID" is not in valid snake_case format, try "$i_d" }}} Follow-up to [28448]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59697 602fd350-edb4-49c9-b593-d223f7449a82
…`body_class`. This changeset introduces new classes to the body tag. The classes `wp-theme-<name>` and `wp-child-theme-<name>` (when the current theme is a child theme) are added, where `<name>` represents the sanitized name of the active theme. Props cais, GaryJ, nacin, SergeyBiryukov, johnjamesjacoby, nirajgirixd, poena, audrasjb, rinkalpagdar. Fixes #19736. git-svn-id: https://develop.svn.wordpress.org/trunk@59698 602fd350-edb4-49c9-b593-d223f7449a82
…_editPost()`. Follow-up to [59697]. Props johnbillion. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59699 602fd350-edb4-49c9-b593-d223f7449a82
This new argument, which defaults to the value of `public`, can be used to determine whether a post can be embedded using oEmbed. A new `is_post_embeddable()` function is added to easily check this. Props pampfelimetten, swissspidy, bradleyt, DrewAPicture, gadelhas, mukesh27. Fixes #35567. git-svn-id: https://develop.svn.wordpress.org/trunk@59700 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the new `import_filters` action hook at the end of the Import screen, consistently with other admin screens like `export.php`. Props audrasjb, lenasterg. Fixes #54419. See #19863. git-svn-id: https://develop.svn.wordpress.org/trunk@59701 602fd350-edb4-49c9-b593-d223f7449a82
…Docs standards; Props ankitpatel1578, sabernhardt. Fixes #62859. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59702 602fd350-edb4-49c9-b593-d223f7449a82
Since [13683], `the_shortlink()` has included a `title` attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it. Props sabernhardt, audrasjb, joedolson. Fixes #62838. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59703 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds more details on the `WP_Term` returned by `get_category()` as it contains additional backwards compatible aliases for the era before WP 4.4 and 2.3. Props apermo, audrasjb. Fixes #62842. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59704 602fd350-edb4-49c9-b593-d223f7449a82
…le::months_dropdown()`. As per the [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#naming-conventions Naming Conventions]: > Don't abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting. Follow-up to [8646], [15491]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59755 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [59736], [59737]. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59756 602fd350-edb4-49c9-b593-d223f7449a82
…missing. Both `name` and `label` properties are required when registering a block style. If the label is missing, assign `name` as the value for the `label`, to ensure the property is defined. This avoids a PHP warning in such case. Props poena, Rahmohn, aaronrobertshaw, audrasjb, rinkalpagdar. Fixes #52592. git-svn-id: https://develop.svn.wordpress.org/trunk@59760 602fd350-edb4-49c9-b593-d223f7449a82
Allow passing zero (`0`) via the `parents` argument. It is a valid value for hierarchical post types, often used to display top-level items. Props mamaduka, audrasjb, peterwilsoncc. Fixes #62901. git-svn-id: https://develop.svn.wordpress.org/trunk@59761 602fd350-edb4-49c9-b593-d223f7449a82
…tation standards. Follow-up to [1345], [8662], [8786], [33624], [34761]. Props kapasias, ankitkumarshah, swissspidy, peterwilsoncc. Fixes #62885. git-svn-id: https://develop.svn.wordpress.org/trunk@59765 602fd350-edb4-49c9-b593-d223f7449a82
Introduces normalization a number of arguments passed to `WP_Query` to increase cache hits for equivalent requests. For example `author__in => [ 1, 2 ]` and `author__in => [ 2, 1 ]` will now hit the same cache. Prior to generating the SQL request and cache key, the following are sorted, made unique and type cast as appropriate. * `post_type` when passed as an array * `post_status` when passed as an array * `term_query`s containing `terms` * `cat` * `category__in` * `category__not_in` * `category__and` * `tag_slug__in` * `tag__in` * `tag__not_in` * `tag__and` * `tag_slug__in` * `tag_slug__and` * `post_parent__not_in` * `author` * `author__not_in` * `author__in` The following are sorted for the purposes of generating the cache key and SQL `WHERE` clause but unmodified for use in the `ORDER BY` SQL clause: * `post_name__in` * `post__in` * `post_parent__in` This commit includes changes to unrelated tests, assertions in `Tests_Query_ParseQuery::test_parse_query_cat_array_mixed()` and `WP_Test_REST_Posts_Controller::test_get_items_not_sticky_with_exclude()` have been modified to account for the sorting of the items above. Props thekt12, peterwilsoncc, spacedmonkey, joemcgill, flixos90, mukesh27, pbearne, swissspidy. Fixes #59516. git-svn-id: https://develop.svn.wordpress.org/trunk@59766 602fd350-edb4-49c9-b593-d223f7449a82
…()`. Includes bringing some consistency with a similar fragment in `WP_List_Table::months_dropdown()`. Follow-up to [3724], [7062], [15491], [59755]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59767 602fd350-edb4-49c9-b593-d223f7449a82
As of UglifyJS >= 3.18.0, the default behavior is to process input as an ES module. This updates the relevant configurations to ensure the build process continues to use the previous behavior to avoid JavaScript errors in the minified versions of files. Follow up to [58563], [58586], and [59509]. Props siliconforks, nataliat2004, poena, mai21, SergeyBiryukov. Fixes #62767. See #61519, #62220. git-svn-id: https://develop.svn.wordpress.org/trunk@59768 602fd350-edb4-49c9-b593-d223f7449a82
The WordPress Importer plugin has been maintained separately in a repository on GitHub since 2016. However, the unit tests were left in wordpress-develop due to the lack of a CI setup on GitHub. With GitHub Actions set up for the plugin repository, these tests are now running in two locations. Because they are more relevant to the plugin itself, the tests have been synced, will run weekly through a `schedule` event, and are now being removed from wordpress-develop. The only remaining test method in the `import` group covers `get_importers()`, which is a function maintained in WordPress Core itself. Props frank-klein, netweb, dd32, peterwilsoncc, azaozz, desrosj, swissspidy. Fixes #42668. git-svn-id: https://develop.svn.wordpress.org/trunk@59769 602fd350-edb4-49c9-b593-d223f7449a82
This fixes a `ReferenceError` caused by a stray Unicode character in the unminified version of moxie.js. This has long been fixed upstream but the library cannot be wholesale updated in WordPress because of an incompatible license change. Because of this, a new version is being tagged, `1.3.5.1`, and the file header has been updated to make it more clear that the file is a maintained fork with a high level list of changes made. Props kinggmobb, jorbin, q0rban, azaozz, desrosj, sukhendu2002. Fixes #59329. git-svn-id: https://develop.svn.wordpress.org/trunk@59770 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [59766]. Props mukesh27. See #59516. git-svn-id: https://develop.svn.wordpress.org/trunk@59771 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [59224]. Add CSS to cover usage of the `do_accordion_section()` function when used in extender contexts outside of the existing WordPress core usage. Props mboynes, jorbin, joemcgill, joedolson. Fixes #62907. git-svn-id: https://develop.svn.wordpress.org/trunk@59772 602fd350-edb4-49c9-b593-d223f7449a82
Hi @draganescu! I'm not sure what you have going on here, but it's resulting in lots of notifications. If you need your fork to be up to date regularly, may I suggest something like https://github.com/marketplace/actions/sync-fork-action? |
This updates the CSS for featured images in the classic editor that caused images to look skewed when auto-sizes are enabled. Props maciejmackowiak, sainathpoojary, mukesh27, joemcgill. Fixes #62597. git-svn-id: https://develop.svn.wordpress.org/trunk@59773 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [24], [114]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59774 602fd350-edb4-49c9-b593-d223f7449a82
Syncs @wordpress/* packages to the 'latest' npm tag. Props mamaduka, joemcgill, youknowriad, swissspidy, sergiomdgomes, gziolo. See #62887. git-svn-id: https://develop.svn.wordpress.org/trunk@59775 602fd350-edb4-49c9-b593-d223f7449a82
This is a follow-up to [59775] to add new files that were missed in the original commit. See #62887. git-svn-id: https://develop.svn.wordpress.org/trunk@59776 602fd350-edb4-49c9-b593-d223f7449a82
This is a follow-up to [59776] and [59775] to add yet another file that was missed in the original commit. See #62887. git-svn-id: https://develop.svn.wordpress.org/trunk@59777 602fd350-edb4-49c9-b593-d223f7449a82
PHP 8.4 introduced four new functions to provide a common way to more easily perform common operations on arrays. - `array_find()`: https://www.php.net/manual/en/function.array-find.php - `array_find_key()`: https://www.php.net/manual/en/function.array-find-key.php - `array_all()`: https://www.php.net/manual/en/function.array-all.php - `array_any()`: https://www.php.net/manual/en/function.array-any.php These functions are now polyfilled making them available on all supported versions of PHP (currently 7.2+). Props Soean, swissspidy, TobiasBg, ayeshrajans, mukesh27, joemcgill. Fixes #62558. git-svn-id: https://develop.svn.wordpress.org/trunk@59783 602fd350-edb4-49c9-b593-d223f7449a82
…ross the administration. This changeset replaces each occurrence of "Add New {Item}" label with "Add {Item}" in WordPress administration, to make the interface more consistent and simplify the translation effort. Props jameskoster, audrasjb, ntsekouras, afercia, peterwilsoncc, youknowriad, joedolson, sukhendu2002, jdy68, beryldlg, fxbenard. See #61219. git-svn-id: https://develop.svn.wordpress.org/trunk@59784 602fd350-edb4-49c9-b593-d223f7449a82
…ol.php`, as per WP Docs standards; See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59785 602fd350-edb4-49c9-b593-d223f7449a82
…ed themes readme files. Follow-up to [59784]. Props jameskoster, audrasjb, ntsekouras, afercia, peterwilsoncc, youknowriad, joedolson, sukhendu2002, jdy68, beryldlg, fxbenard. Fixes #61219. git-svn-id: https://develop.svn.wordpress.org/trunk@59786 602fd350-edb4-49c9-b593-d223f7449a82
…toload_value()`, as per WP Docs standards. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59787 602fd350-edb4-49c9-b593-d223f7449a82
…`::is_single()`. Follow-up to [29039]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59788 602fd350-edb4-49c9-b593-d223f7449a82
This changeset improves a bunch of WP-Admin error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information. Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson. See #43622. git-svn-id: https://develop.svn.wordpress.org/trunk@59789 602fd350-edb4-49c9-b593-d223f7449a82
This changeset improves a bunch of error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information. Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson. Fixes #43622. git-svn-id: https://develop.svn.wordpress.org/trunk@59790 602fd350-edb4-49c9-b593-d223f7449a82
…pe` class. Follow-up to [59784], [59786]. Fixes #61219. git-svn-id: https://develop.svn.wordpress.org/trunk@59791 602fd350-edb4-49c9-b593-d223f7449a82
… `::have_posts()`. Follow-up to [2716], [2741], [11464]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59792 602fd350-edb4-49c9-b593-d223f7449a82
Updates the enqueued styles in various editors to remove target styles more precisely to where they are needed. Removes the following stylesheets as dependencies of `wp-edit-blocks`: * `wp-editor` * `wp-reusable-blocks` * `wp-patterns` The `wp-editor` stylesheet is targeted to the items requiring the CSS: * `edit-widgets` * `customize-widgets` * `edit-site` Props ellatrix, youknowriad. Fixes #62266, #62274. git-svn-id: https://develop.svn.wordpress.org/trunk@59793 602fd350-edb4-49c9-b593-d223f7449a82
The site editor now uses path based routing rather than query string arguments. This redirects the legacy query string URLs to the new routing. Props youknowriad, peterwilsoncc, joemcgill, mukesh27, poena. Fixes #62585. git-svn-id: https://develop.svn.wordpress.org/trunk@59794 602fd350-edb4-49c9-b593-d223f7449a82
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )