Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEXPIRE in 1.11.0 breaks TTL in some cases #2105

Closed
Letfdsada opened this issue Nov 1, 2023 · 2 comments
Closed

PEXPIRE in 1.11.0 breaks TTL in some cases #2105

Letfdsada opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Letfdsada
Copy link
Contributor

Letfdsada commented Nov 1, 2023

Describe the bug
I'm using code that updates keys TTL in the background using a Lua script. With update 1.11.0 i noticed that keys ttl has become huge.
Behaviour is normal in 1.10.0.

To Reproduce
Steps to reproduce the behavior:

  1. Create string: set key value
  2. Execute lua script: eval "redis.call('pexpire', KEYS[1], ARGV[1])" 1 key
  3. See huge ttl: ttl key

Expected behavior
I expect that when using PEXPIRE 60000, keys ttl will become 60 seconds.

Screenshots

https://youtu.be/V-pEatTKB6A

Environment (please complete the following information):

  • OS: Ubuntu 20.04.6 LTS
  • Kernel: Linux ***** 5.15.90.1-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux, Linux ***** 5.4.0-155-generic #172-Ubuntu SMP Fri Jul 7 16:10:02 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • Containerized?: Yes (Docker, Kubernetes)
  • Dragonfly Version: 1.11.0 (does not appear in 1.10.0)

Reproducible Code Snippet

redis-cli
set key value px 60000
eval "redis.call('pexpire', KEYS[1], ARGV[1])" 1 key 60000
ttl key

Additional context
Add any other context about the problem here.

@Letfdsada Letfdsada added the bug Something isn't working label Nov 1, 2023
@Letfdsada
Copy link
Contributor Author

Perhaps you know something? @dranikpg @kostasrim

@dranikpg
Copy link
Contributor

dranikpg commented Nov 1, 2023

Yes, I do know something 😄 Unfortunately it did break indeed... 😢 The issue is already fixed: #2080

We are most likely planning to release a patch version by the end of this week / next week that will include this fix, so please stay tuned

Thanks for reporting!

@dranikpg dranikpg closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants