fix(server): Correctly set expiration from Lua scripts

[chakaz]

We used to set time_now_ms_ only in the non-squashed execution path.

Fixes #2034

[dranikpg]

I agree there is a bug, but this is not the fix 🙂

In the regular case time_now_ms_ is assigned only during scheduling (and for a multi transaction it keeps that value till the end)

How does it work with squashing? You can see that the stub-tx has a dedicated constructor which already assigns time_now_ms_ from the parent (so this change would break atomicity for multi/exec squashing)

What's wrong with single-shard-lua: The parent transaction did not schedule when we create the stub tx, so time-now-is is 0 (also I just remember that txid = 0 as well)

What would be the simplest solution? To create the stub-tx inside the callback, it should fix all problems because now initialization would happen as planned. Otherwise... Create something like a special init / assignment operator function for the stub tx to re-fetch data from its main tx (txid & time_now_)

BTW, we have a similar bug with pipeline squashing, where the value is not updated 🙄 Will fix it!

[chakaz]

Nice catch! And indeed, your proposal fixes the issue.

[dranikpg]

👍🏻