Check code with static analyzers

[BorysTheDev]

I will add here bugs that I found with static analysis

[BorysTheDev]

`void Scheduler::ScheduleFromRemote(FiberInterface* cntx) {
// This function is called from FiberInterface::ActivateOther from a remote scheduler.
// But the fiber belongs to this scheduler.
DCHECK(cntx->scheduler_ == this);

// If someone else holds the bit - give up on scheduling by this call.
// This should not happen as ScheduleFromRemote should be called under a WaitQueue lock.
if ((cntx->flags_.fetch_or(FiberInterface::kScheduleRemote, memory_order_acquire) &
FiberInterface::kScheduleRemote) == 1) {
LOG(DFATAL) << "Already scheduled remotely " << cntx->name();
return;
}`

if ((cntx->flags_.fetch_or(FiberInterface::kScheduleRemote, memory_order_acquire) & FiberInterface::kScheduleRemote) == 1) is always false

[BorysTheDev]

optional<Transaction::MultiMode> multi_mode = DeduceExecMode(state, exec_info, *script_mgr()); if (!multi_mode) return rb->SendError( "Dragonfly does not allow execution of a server-side Lua in Multi transaction");

condition is always false

[romange]

@BorysTheDev we should integrate it into our codebase and our test runs :)

[BorysTheDev]

OpStatus OpSetId2(const OpArgs& op_args, string_view key, const streamID& sid) {
....
long long entries_added = -1;
....
if (entries_added != -1)

[BorysTheDev]

size_t node_max_bytes = kStreamNodeMaxBytes;
if (node_max_bytes == 0 || node_max_bytes > STREAM_LISTPACK_MAX_SIZE)
node_max_bytes = STREAM_LISTPACK_MAX_SIZE;

[BorysTheDev]

DCHECK(it == blocks_.begin() || it == blocks_.begin() || it->Size() * 2 >= block_size_);

duplication check, maybe a bug

[dranikpg]

   if (!conn_state.subscribe_info->channels.empty()) {
     server_cntx->UnsubscribeAll(false);
   }

   if (conn_state.subscribe_info) { // always true
     DCHECK(!conn_state.subscribe_info->patterns.empty());
     server_cntx->PUnsubscribeAll(false);
   }

   DCHECK(!conn_state.subscribe_info);
 }

UnsubscribeAll can call conn_state.reset(), so how is it always true? 🤔

[BorysTheDev]

I think it's a false positive, I haven't dived deep when I analyzed the static analysis results. You can hide the comment and I will know that I was wrong regarding it