Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new flag replica no reconnect on master restart #3192

Closed
adiholden opened this issue Jun 19, 2024 · 0 comments · Fixed by #3193
Closed

create new flag replica no reconnect on master restart #3192

adiholden opened this issue Jun 19, 2024 · 0 comments · Fixed by #3193
Assignees
@chakaz
Labels
bug Something isn't working

Comments

@adiholden
Copy link
Collaborator

deprecate replica_reconnect_on_master_restart
@adiholden adiholden added the bug Something isn't working label Jun 19, 2024
@chakaz chakaz mentioned this issue Jun 19, 2024
Merged
@chakaz chakaz closed this as completed in 43d7993 Jun 20, 2024
dranikpg pushed a commit to dranikpg/dragonfly that referenced this issue Jun 23, 2024
@chakaz @dranikpg
fix(server): Rename confusing flag `replica_reconnect_on_master_resta…
f0064d8 
…rt` (dragonflydb#3193)

That was a misleading name, as the logic was the exact opposite (oops 🤦)

This PR introduces a new name for the same flag: break_replication_on_master_restart

We're keeping the previous flag for now, to make transition easier. We'll remove it in a later Dragonfly version (>= 1.22)

Fixes dragonflydb#3192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): Rename confusing flag replica_reconnect_on_master_restart dragonflydb/dragonfly
2 participants
@chakaz @adiholden