Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for monitor command #344

Closed
boazsade opened this issue Oct 3, 2022 · 0 comments
Closed

Support for monitor command #344

boazsade opened this issue Oct 3, 2022 · 0 comments
Assignees

Comments

@boazsade
Copy link
Contributor

boazsade commented Oct 3, 2022

Is your feature request related to a problem? Please describe.
This is required in order to be able to use resp.app tool. The tool has a button at the man window that is running monitor on the connection. See details on the monitor command in the redis documentation.
In order to provide the user with the same level of experience as would get working against redis, this command need to be supported.

Describe the solution you'd like
Currently Dragonfly is not yet supporting this command - see API status. This is an enhancement to missing API.
Describe alternatives you've considered
You can track the commands that were run by the user using the log on dragonfly (dragonfly --vmodule=main_service=2 --logbuflevel=-1 --alsologtostderr), but when using tools such as resp.app you would not be able to do so.

Additional context
This is kind of a must for the complete user experience with resp.app and it would allow for easy command debugging tool for the users.

@boazsade boazsade self-assigned this Oct 3, 2022
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 20, 2022
refactor for the request message to dispatch async. (dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 20, 2022
feat(server): support for monitor command. add filters and support for auth not showing sensitive data (dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 20, 2022
…now support monitor type as well. (dragonflydb#344)

feat(server): monitor command, add command filters

feat(server): support for monitor command. spport for auth not showing sensitive data (dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 21, 2022
…now support monitor type as well. (dragonflydb#344)

feat(server): monitor command, add command filters

feat(server): support for monitor command. spport for auth not showing sensitive data (dragonflydb#344)

feat(server): monitor command output format support none pritable char as well

feat(server): monitor command - move monitor handling after verify and run other command, add cleanup when connection closed (dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 21, 2022
…now support monitor type as well. (dragonflydb#344)

feat(server): monitor command, add command filters

feat(server): support for monitor command. spport for auth not showing sensitive data (dragonflydb#344)

feat(server): monitor command output format support none pritable char as well

feat(server): monitor command - move monitor handling after verify and run other command, add cleanup when connection closed (dragonflydb#344)

feat(server): monitor command - disable by default (dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 24, 2022
monitor all commands running on all other connections (dragonflydb#344).

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 24, 2022
from all connections by using a connection as monitors for the this
(dragonflydb#344)

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 24, 2022
from all connections by using a connection as monitors for the this
(dragonflydb#344)

feat(server): monitor command - remove dead code, simplfy code that is not needed

Signed-off-by: Boaz Sade <[email protected]>
romange pushed a commit that referenced this issue Oct 24, 2022
feat(server): support monitor command - allowing user to debug commands
from all connections by using a connection as monitors for the this
(#344)

Signed-off-by: Boaz Sade <[email protected]>
@romange romange closed this as completed Oct 24, 2022
boazsade added a commit to boazsade/dragonfly that referenced this issue Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants