Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_replication_all fails #4150

Closed
kostasrim opened this issue Nov 19, 2024 · 0 comments · Fixed by #4155
Closed

test_replication_all fails #4150

kostasrim opened this issue Nov 19, 2024 · 0 comments · Fixed by #4155
Assignees
@romange
Labels
bug Something isn't working failing-test

Comments

@kostasrim
Copy link
Contributor

https://github.com/dragonflydb/dragonfly/actions/runs/11907164782/job/33180402391#step:6:1013

Assert fail:

    async def check():
        await check_all_replicas_finished(c_replicas, c_master)
        hashes = await asyncio.gather(*(SeederV2.capture(c) for c in [c_master] + c_replicas))
>       assert len(set(hashes)) == 1
E       assert 2 == 1
@kostasrim kostasrim added bug Something isn't working failing-test labels Nov 19, 2024
@romange romange self-assigned this Nov 19, 2024
romange added a commit that referenced this issue Nov 19, 2024
@romange
fix: test_replication_all failure
5f66b76 
Fixes #4150. The failure can be reproduced with high probability on ARM via
`pytest dragonfly/replication_test.py -k test_replication_all[df_factory0-mode0-8-t_replicas3-seeder_config3-2000-False]`

Not sure why this barrier is needed but #4146 removes the barrier
which breaks a gentle balance in the code in unexpected way.

Signed-off-by: Roman Gershman <[email protected]>
@romange romange mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romange romange

Labels
bug Something isn't working failing-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: test_replication_all failure dragonflydb/dragonfly
2 participants
@romange @kostasrim