-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus metrics broken on prom 3.0 #4277
Comments
@ishioni should be easy to fix. would you like to take a stab on it? |
Wish I could - last time I touched cpp was over a decade ago in college |
I added this to prometheus.yml meanwhile.
|
How do you enable this in the Prometheus Operator? |
A more targeted solution for now is to apply a Full example:
|
How do I reproduce it locally? Running the latest version of prometheus is enough? |
Yes sir, running Prometheus 3 is enough to reproduce it. The /metrics endpoint does not return a Content-Type header. From the migration guide
|
Also, update the local stack to use prometheus 3.0 Finally, hex-escape arguments when logging an error for a command. Fixes #4277 Signed-off-by: Roman Gershman <[email protected]>
Describe the bug
Prometheus 3.0 rejects the scrape because dragonfly does not set content-type
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Prometheus metrics should work
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
Additional context
Setting something like
content-type text/plain; version=0.0.4; charset=utf-8; escaping=underscores
should be enough to make it work. Adding a fallback_scrape_protocol should be good as well, but the prometheus operator CRDs don't allow that unfortunately
More context https://prometheus.io/docs/prometheus/3.0/migration/#scrape-protocols
The text was updated successfully, but these errors were encountered: