Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support redis-sentinel #706

Closed
ashotland opened this issue Jan 19, 2023 · 0 comments
Closed

Support redis-sentinel #706

ashotland opened this issue Jan 19, 2023 · 0 comments
Assignees
@ashotland

Comments

@ashotland
Copy link
Contributor

ashotland commented Jan 19, 2023 •
edited
Loading

1. Report slaves in INFO REPLICATION

DF info replication doesn't list the slaves so redis-sentinel has no way to discover them.

Example line:
slave0:ip=172.19.0.3,port=6379,state=online,offset=2816,lag=1

Peeking into redis-sentinel code only ip and port are needed.
https://github.com/redis/redis/blob/unstable/src/sentinel.c#L2551

2 Support the following transaction
(Currently dragonfly doesn't allow admin commands in a transaction)

redis-sentinel send a transaction with
slaveof
config rewrite
client kill

See https://github.com/redis/redis/blob/unstable/src/sentinel.c#L4807
@ashotland ashotland changed the title Report slaves in INFO REPLICATION Support redis-sentinel Jan 20, 2023
ashotland added a commit that referenced this issue Jan 22, 2023
@ashotland
feat(server): reprot slaves ip and listening port in INFO REPLICATION
79cf04f 
See #706 for more context

Signed-off-by: ashotland <[email protected]>
ashotland added a commit that referenced this issue Jan 22, 2023
@ashotland
feat(server): report slaves ip and listening port in INFO REPLICATION
a9e0c78 
See #706 for more context

Signed-off-by: ashotland <[email protected]>
@ashotland ashotland mentioned this issue Jan 22, 2023
Merged
ashotland added a commit that referenced this issue Jan 22, 2023
@ashotland
feat(server): report slaves ip and listening port in INFO REPLICATION
bd9eaf8 
See #706 for more context

Signed-off-by: ashotland <[email protected]>
Signed-off-by: ashotland <[email protected]>
ashotland added a commit that referenced this issue Jan 22, 2023
@ashotland
feat(server): report slaves ip and listening port in INFO REPLICATION
e7c97a4 
See #706 for more context

Signed-off-by: ashotland <[email protected]>
ashotland added a commit that referenced this issue Jan 22, 2023
@ashotland
feat(server): report slaves ip and listening port in INFO REPLICATION (…
bdfdc7d 
…#715)

See #706 for more context

Signed-off-by: ashotland <[email protected]>

Signed-off-by: ashotland <[email protected]>
@ashotland ashotland self-assigned this Jan 22, 2023
ashotland added a commit that referenced this issue Jan 24, 2023
@ashotland
feat(server): Allow admin commands in multi
d56a222 
Needed for sentinel support (#706)

Signed-off-by: ashotland <[email protected]>
@ashotland ashotland mentioned this issue Jan 24, 2023
Merged
ashotland added a commit that referenced this issue Jan 24, 2023
@ashotland
feat(server): Allow admin commands in multi (#722)
59bfeca 
Needed for sentinel support (#706)

Signed-off-by: ashotland <[email protected]>

Signed-off-by: ashotland <[email protected]>
ashotland added a commit that referenced this issue Jan 29, 2023
@ashotland
feat(test): Sentinel Integration Test (#728)
b00e83e 
* feat(server): Allow admin commands in multi

Needed for sentinel support (#706)

Signed-off-by: ashotland <[email protected]>

* feat(server): Add test coverage for multi global commands

Signed-off-by: ashotland <[email protected]>

* code review fixes

Signed-off-by: ashotland <[email protected]>

* Sentinel integration test

Signed-off-by: ashotland <[email protected]>

---------

Signed-off-by: ashotland <[email protected]>
ashotland added a commit that referenced this issue Jan 30, 2023
@ashotland
chore(tests): Sentinel test PR code review followup (#731)
29d47cd 
* feat(server): Allow admin commands in multi

Needed for sentinel support (#706)

Signed-off-by: ashotland <[email protected]>

* feat(server): Add test coverage for multi global commands

Signed-off-by: ashotland <[email protected]>

* code review fixes

Signed-off-by: ashotland <[email protected]>

* Sentinel integration test

Signed-off-by: ashotland <[email protected]>

* PR code reiew follow up
Have lambda return awaitable instead of defining neoff async function

Signed-off-by: ashotland <[email protected]>

---------

Signed-off-by: ashotland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashotland ashotland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashotland