Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove fiber related names from the codebase #1018

Merged
merged 1 commit into from
Mar 31, 2023
Merged

chore: remove fiber related names from the codebase #1018

merged 1 commit into from
Mar 31, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented Mar 31, 2023

Remove Boost.Fibers mentions and remove fibers_ext mentions. Done in preparation to switch to helio-native fb2 implementation.

@romange romange requested a review from dranikpg March 31, 2023 06:51
@romange
chore: remove fiber related names from the codebase
b970022 
Remove Boost.Fibers mentions and remove fibers_ext mentions.
Done in preparation to switch to helio-native fb2 implementation.

Signed-off-by: Roman Gershman <[email protected]>
dranikpg
dranikpg approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@dranikpg dranikpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping them in a separate namespace (with a shorter name) was also an option. Currently most object files have:

  • the whole dfly namespace
  • using namespace std
  • using namespace facade
  • and now the helio stuff

A little much, but works allright 🙂

@romange
Copy link
Collaborator Author

romange commented Mar 31, 2023

After the switch we will work on naming in helio :)

@romange romange merged commit 0cbd5f0 into main Mar 31, 2023
@romange romange deleted the CleanFiberNames branch March 31, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dranikpg dranikpg dranikpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romange @dranikpg