chore: update jsoncons dependency #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iko1 seems like the new version does not compile in Dragonfly. |
A fix will be sent shortly |
iko1
force-pushed
the
fix/upgrade-jsoncons-dep
branch
from
1c7c4ca to
f52be4a
Compare
romange
reviewed
Apr 13, 2023
src/core/json_test.cc
Outdated
| json j1 = R"({"c":{"a":1, "b":2}, "d":{"a":1, "b":2, "c":3}, "e": [1,2]})"_json; | ||
| struct pmr_sorted_policy : public sorted_policy { | ||
| template<class T, class Allocator> | ||
| using vector = std::vector<T, std::pmr::polymorphic_allocator<T>>; |
There was a problem hiding this comment.
you can use std::pmr::vector
romange
reviewed
Apr 13, 2023
src/core/json_test.cc
Outdated
| using array = json_array<Json,vector>; | ||
|
|
||
| template <class CharT, class CharTraits, class Allocator> | ||
| using string = std::basic_string<CharT, CharTraits, std::pmr::polymorphic_allocator<CharT>>; |
iko1
force-pushed
the
fix/upgrade-jsoncons-dep
branch
from
f52be4a to
492dbee
Compare
iko1
force-pushed
the
fix/upgrade-jsoncons-dep
branch
from
492dbee to
abe86fc
Compare
|
@iko1 I think the allocator fixes didn't got into the 0.170 release branch. |
iko1
force-pushed
the
fix/upgrade-jsoncons-dep
branch
2 times, most recently
from
c946b04 to
2905c70
Compare
Signed-off-by: iko1 <[email protected]>
Signed-off-by: iko1 <[email protected]>
Signed-off-by: iko1 <[email protected]>
Signed-off-by: iko1 <[email protected]>
iko1
force-pushed
the
fix/upgrade-jsoncons-dep
branch
from
2905c70 to
49ab388
Compare
The allocator fixes got into the jsoncons 0.171.0 release |
|
@iko1 thanks, looks like the new version works correctly! We're going to have a new release soon, so to minimize disruption I'm going to merge this right afterwards. |
romange
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of jsoncons includes a few bug fixes and performance enhancements
Moreover, it contains the fix that allows the jsoncons to use mimalloc allocator instead of the standard allocator.