Remove blpop FindFirst hop after wakeup #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
reviewed
May 1, 2023
src/server/transaction.cc
Outdated
| // We don't care about preserving the strict order with multiple operations running on blocking | ||
| // keys in parallel, because the internal order is not observable from outside either way. | ||
| uint64_t default_txid = UINT64_MAX; | ||
| if (!notify_txid_.compare_exchange_weak(default_txid, committed_txid, memory_order_relaxed)) |
There was a problem hiding this comment.
compare_exchange_weak is an overkill for "run-once" semantics.
Also, I wonder if notify_txid_ is needed after this change or it's been used only here
There was a problem hiding this comment.
Indeed, I forgot to simplify FindFirst.
compare_exchange_weak is an overkill for "run-once" semantics.
How else should I do run-once? 👀
There was a problem hiding this comment.
for example,
if (var.fetch_add(1, relaxed) == 0) {
}
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
|
I checked the ruby playground and it seems to work (worker rb + loadtest) |
romange
approved these changes
May 3, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1153
Adds the following changes: