Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor RunCbOnFirstNonEmptyBlocking #1608

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: refactor RunCbOnFirstNonEmptyBlocking #1608

merged 1 commit into from
Jul 31, 2023

Conversation

dranikpg
Copy link
Contributor

I refactored RunCbOnFirstNonEmptyBlocking a little to be more readable and easier to understand

  1. I've explicitly split the callback invocation into expiry/non expiry path (I remember Roman once asked for this). The code flow is linear now and easier to grasp
  2. Added some high level comments for logic
  3. Some small changes

Shouldn't include any functional changes

@dranikpg dranikpg requested a review from royjacobson July 31, 2023 12:14
adiholden
adiholden previously approved these changes Jul 31, 2023
View reviewed changes
@dranikpg dranikpg force-pushed the fix-blocking-tx-2 branch from 4668f70 to cd1abd5 Compare July 31, 2023 13:36
@dranikpg dranikpg merged commit 7673e02 into dragonflydb:main Jul 31, 2023
romange added a commit that referenced this pull request Aug 1, 2023
@romange
Revert "fix: refactor RunCbOnFirstNonEmptyBlocking (#1608)"
9d93e6f 
This reverts commit 7673e02.
@dranikpg dranikpg deleted the fix-blocking-tx-2 branch August 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiholden adiholden adiholden approved these changes

@royjacobson royjacobson Awaiting requested review from royjacobson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dranikpg @adiholden