Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VersionMonitor): request to update on older version #1674

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(VersionMonitor): request to update on older version #1674

merged 1 commit into from
Aug 9, 2023

Conversation

kostasrim
Copy link
Contributor

Fix the improper log to update on an older version.

I hardcode tested this locally with with the following:

  1. remote = 1.8.0 curr = 1.7.0
  2. remote = 1.8.0 curr = 1.8.0
  3. remote = 1.8.0 curr = 1.8.1

@kostasrim kostasrim self-assigned this Aug 9, 2023
@kostasrim kostasrim requested review from romange and chakaz August 9, 2023 09:02
@kostasrim kostasrim enabled auto-merge (squash) August 9, 2023 09:06
chakaz
chakaz approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@kostasrim kostasrim merged commit 52442c4 into main Aug 9, 2023
@kostasrim kostasrim deleted the fix_version_monitor branch August 9, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakaz chakaz chakaz approved these changes

@romange romange romange approved these changes

Assignees

@kostasrim kostasrim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostasrim @romange @chakaz