Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend CI running time #1749

Merged
merged 1 commit into from
Aug 27, 2023
Merged

fix: extend CI running time #1749

merged 1 commit into from
Aug 27, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented Aug 27, 2023

Also, add sccache debug log in hope to understand
why we get 0 hits sometimes.

Also, add sccache debug log in hope to understand
why we get 0 hits sometimes.

Signed-off-by: Roman Gershman <[email protected]>
@romange romange requested a review from royjacobson August 27, 2023 07:27
@royjacobson
Copy link
Contributor

about the 0 hits issue: from what I understand, every branch/PR is sandboxed, cache wise. This is why I wanted to move to GCS.

https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

They say there's a way to access caches from the main branch, but maybe it requires some special handling or something

@romange
Copy link
Collaborator Author

romange commented Aug 27, 2023

@royjacobson I think it applies specifically to github actions/cache. i.e. how cache keys are stored. Here, sccache manages its own logic. Are you saying that Azure cloud storage is sandboxed?

@romange
Copy link
Collaborator Author

romange commented Aug 27, 2023

oh, you are right. GHA is not azure storage, it's github actions cache :(

@romange romange merged commit 8ebfd15 into main Aug 27, 2023
@romange romange deleted the Pr1 branch August 27, 2023 07:57
kostasrim pushed a commit that referenced this pull request Aug 29, 2023
Also, add sccache debug log in hope to understand
why we get 0 hits sometimes.

Signed-off-by: Roman Gershman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants