feat: introduce configurable flags for I/O limits #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
ConfigLimits
branch
2 times, most recently
from
1f270c0 to
6ae5e19
Compare
|
Looks Ok. A bit sad that there are two independent flags and both need to sort of be in agreement with each other. But I also don't see a good way around it. The tests fail, though :) |
Introduced `max_multi_bulk_len` as a max limit when parsing RESP arrays as well as `max_client_iobuf_len` as a max limit on the iobuf used to read from a socket. Signed-off-by: Roman Gershman <[email protected]>
|
@royjacobson PTAL |
royjacobson
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
max_multi_bulk_lenas a max limit when parsing RESP arraysas well as
max_client_iobuf_lenas a max limit on the iobuf used toread from a socket.