chore: dragonfly compiles on FreeBSD #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romange
commented
Sep 3, 2023
•
romange
commented
- Do not use IOUring on non-linux systems.
- Improve compatibility of the code for non-linux systems.
- pull helio
chakaz
previously approved these changes
Sep 3, 2023
1. Do not use IOUring on non-linux systems. 2. Improve compatibility of the code for non-linux systems. Signed-off-by: Roman Gershman <[email protected]>
|
pulled helio again |
chakaz
approved these changes
Sep 3, 2023
royjacobson
reviewed
Sep 3, 2023
| @@ -109,6 +109,17 @@ unsigned NumPagesInSegment(PageClass pc) { | |||
| return 0; | |||
| } | |||
|
|
|||
| template <size_t N> size_t FindFirst(const std::bitset<N>& bs) { | |||
There was a problem hiding this comment.
I was hoping compilers would recognize the pattern, but on compiler explorer it looks like both GCC and clang can't do it :/
If we ever really care enough about libc++ performance we might need to abandon std::bitset and implement this ourselves.
There was a problem hiding this comment.
(I don't think we care enough about libc++ right now, though)
There was a problem hiding this comment.
we do not care. moreover, I still can not link dragonfly with clang. has weird missing symbol errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.