Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update double-conversion library #1793

Merged
merged 1 commit into from
Sep 3, 2023
Merged

chore: Update double-conversion library #1793

merged 1 commit into from
Sep 3, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented Sep 3, 2023

Add double to string coversion tests.
Patch the library to avoid using locale - because freebsd c++ lib does not have this symbol.

changing this function: https://github.com/google/double-conversion/blob/master/double-conversion/string-to-double.cc#L55

Add double to string coversion tests.
Patch the library to avoid using locale - because freebsd c++ lib
does not have this symbol.

Signed-off-by: Roman Gershman <[email protected]>
@romange romange requested a review from royjacobson September 3, 2023 12:27
@romange romange merged commit cc828f2 into main Sep 3, 2023
@romange romange deleted the Pr1 branch September 3, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants