feat(search): HNSW #1799
Merged
feat(search): HNSW #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
search-hnsw
branch
2 times, most recently
from
70d8c59 to
56fe552
Compare
dranikpg
force-pushed
the
search-hnsw
branch
from
56fe552 to
5e08d22
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
search-hnsw
branch
from
5e08d22 to
d870abb
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
chakaz
previously approved these changes
Sep 7, 2023
| } | ||
|
|
||
| private: | ||
| using SpaceUnion = std::variant<hnswlib::L2Space, hnswlib::InnerProductSpace>; |
|
|
||
| bool use_hnsw = parser->ToUpper().Next().Case("HNSW", true).Case("FLAT", false); |
There was a problem hiding this comment.
Better than 5+ lines if {} else if {} else reply 😼 (because we need to report if its neither flat or hnsw and the argument parser does this under the hood)
There was a problem hiding this comment.
Don't get me wrong, I'm not saying it's bad. It's great, readable, no complaints.
I was just blown away that this is C++ and not, idk, Python 🤣
There was a problem hiding this comment.
Properly designed C++ code can be cool as well 🤓 🧙🏻
There was a problem hiding this comment.
Don't get me wrong, I'm not saying it's bad. It's great, readable, no complaints.
I was just blown away that this is C++ and not, idk, Python
How do you feel about std::ranges then ? 😛
dranikpg
force-pushed
the
search-hnsw
branch
from
1050409 to
1f17f56
Compare
chakaz
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.