fix(regression-tests): correct path for acl files #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
reviewed
Sep 9, 2023
Comment on lines
249
to
+254
| @pytest.mark.asyncio | ||
| @dfly_args( | ||
| { | ||
| "aclfile": os.environ.get( | ||
| "DRAGONFLY_PATH/ok.acl", os.path.join(SCRIPTS_DIR, "../../build-dbg/ok.acl") | ||
| ), | ||
| "port": 1111, | ||
| } | ||
| ) | ||
| @dfly_args({"port": 1111}) | ||
| async def test_good_acl_file(df_local_factory): | ||
| df = df_local_factory.create() | ||
| path = df_local_factory.params.path | ||
| acl = os.path.join(os.path.dirname(path), "ok.acl") | ||
| df = df_local_factory.create(aclfile=acl) |
There was a problem hiding this comment.
See how easier it would've been to place them just locally 😝
And now you use @dfly_args with a random port to move the default instance out of the way
There was a problem hiding this comment.
See how easier it would've been to place them just locally
That's exactly what you suggested 🤣
And now you use @dfly_args with a random port to move the default instance out of the way
I will patch this on the next PR, I will make changes anyway so I didn;t bother
dranikpg
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that we appended the aclfile name onto the dragonfly binary (path + binary name). This ofc would break