chore: add balls and bins simulator #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Gershman <[email protected]>
kostasrim
previously approved these changes
Oct 10, 2023
tools/balls_bins.py
Outdated
| import matplotlib.pyplot as plt | ||
|
|
||
|
|
||
| def simulate_balls_into_bins(balls: int, N, threshold: int, exact, trials=10000): |
There was a problem hiding this comment.
tiny nit, if you plan to expand this in the future, replace N with bins since you already use balls instead of M
| print( | ||
| f"Histogram of the difference between the most and least populated bins for {args.trials} trials" | ||
| ) | ||
| plt.hist(deltas, bins=30, color="steelblue", edgecolor="none") |
There was a problem hiding this comment.
Why are you limiting to 30 bins? I guess if we experiment with a large size of args.bins we will get large deltas and a lot of the data points will end up on the last bucket (bin 30). Is this intented?
There was a problem hiding this comment.
30 bins is 30 buckets that I assume would be defined according to the data distribution (auto bins).
|
pre-approved so I don't block you, if you think some of my comments are applicable let me know :) |
Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.