chore: call debug stacktrace on SIGUSR1 #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kostasrim
commented
Oct 11, 2023
•
kostasrim
commented
- add macro to install a signal handler that prints the contents of debug stacktrace on SIGUSR1
- add this on regTests
kostasrim
force-pushed
the
add_debug_stacktrace
branch
from
cee013c to
0f7ddf5
Compare
kostasrim
changed the title
dranikpg
previously approved these changes
Oct 18, 2023
Comment on lines
+159
to
+161
| # Even worse, on SIGTERM and SIGKILL none of the handlers registered via sigaction | ||
| # are guranteed to run | ||
| time.sleep(5) |
There was a problem hiding this comment.
if it becomes an issue we can just send sigusr unconditionally, however it'll pollute the logs where deadlocking is not an issue
romange
reviewed
Oct 19, 2023
src/server/CMakeLists.txt
Outdated
| @@ -44,6 +42,13 @@ add_library(dragonfly_lib engine_shard_set.cc channel_store.cc command_registry. | |||
| cluster/cluster_family.cc acl/user.cc acl/user_registry.cc acl/acl_family.cc | |||
| acl/validator.cc acl/helpers.cc) | |||
|
|
|||
| cxx_link(dfly_transaction dfly_core strings_lib TRDP::fast_float) | |||
|
|
|||
| option(PRINT_STACKTRACES_ON_SIGNAL "Enables DF to print all fiber stacktraces on SIGKILL" OFF) | |||
dranikpg
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.