Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to set snapshot_cron flag during runtime(#1762) #2101

Merged
merged 4 commits into from
Nov 3, 2023
Merged

add ability to set snapshot_cron flag during runtime(#1762) #2101

merged 4 commits into from
Nov 3, 2023

Conversation

BorysTheDev
Copy link
Contributor

@BorysTheDev BorysTheDev commented Nov 1, 2023 •
edited by romange
Loading

Fixes #1762

chakaz
chakaz reviewed Nov 1, 2023
View reviewed changes
src/server/server_family.cc Show resolved Hide resolved
src/server/server_family.cc Outdated Show resolved Hide resolved
src/server/server_family.cc Outdated Show resolved Hide resolved
@romange romange requested a review from adiholden November 1, 2023 14:18
@BorysTheDev BorysTheDev requested a review from chakaz November 1, 2023 14:19
romange
romange reviewed Nov 1, 2023
View reviewed changes
src/server/server_family.cc Outdated Show resolved Hide resolved
@adiholden
Copy link
Collaborator

@BorysTheDev please used signed commits (git commit -s)

@adiholden
Copy link
Collaborator

also commit message will follow the following convention
([optional scope]):
f.e feat(snapshot): support set snapshot_cron during runtime

@BorysTheDev
Copy link
Contributor Author

@BorysTheDev please used signed commits (git commit -s)

It looks I have done an incorrect gpg key setup, I will check my configuration

@BorysTheDev BorysTheDev requested a review from adiholden November 1, 2023 18:29
@BorysTheDev BorysTheDev requested a review from romange November 2, 2023 08:23
chakaz
chakaz approved these changes Nov 3, 2023
View reviewed changes
src/server/server_family.cc Show resolved Hide resolved
@BorysTheDev BorysTheDev merged commit 2f39e89 into main Nov 3, 2023
7 checks passed
@BorysTheDev BorysTheDev deleted the snapshot_cron_issue branch November 3, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakaz chakaz chakaz approved these changes

@romange romange romange approved these changes

@adiholden adiholden Awaiting requested review from adiholden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snapshot_cron can not be changed at runtime
4 participants
@BorysTheDev @adiholden @romange @chakaz