Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local grafana dasboard #2124

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: local grafana dasboard #2124

merged 1 commit into from
Nov 4, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented Nov 4, 2023

The dashboard used dragonfly_up metric to boostrap itself but this metric does not exist anymore. I replaced it with dragonfly_version In addition, the exported format changed slightly because I used the recent grafana version to export.

The dashboard used `dragonfly_up` metric to boostrap itself
but this metric does not exist anymore. I replaced it with `dragonfly_version`
In addition, the exported format changed slightly because I used the
recent grafana version to export.

Signed-off-by: Roman Gershman <[email protected]>
@romange romange requested a review from chakaz November 4, 2023 17:57
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally and completely rubber stamping, I have no idea what I just read 🤣
If you're looking for an actual review, add someone else 🙃

@romange romange enabled auto-merge (squash) November 4, 2023 18:23
@romange romange merged commit 5c6aad2 into main Nov 4, 2023
10 checks passed
@romange romange deleted the Pr1 branch November 4, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants