fix(unittest): Init with dbfilename= before attempting to save
#2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty recent regression.
|
What has changed? Why do we need to reset the service now with |
romange
reviewed
Nov 5, 2023
| unlink(fl.name.c_str()); | ||
| } | ||
| BaseFamilyTest::TearDown(); | ||
| InitWithDbFilename(); |
There was a problem hiding this comment.
Ok, I understand now the context but I think for these tests SetFlag(&FLAGS_dbfilename, "rdbtestdump"); is enough.
There was a problem hiding this comment.
Even if not, that's a good infra to have, which already semi exists for rdb_test, I think it's better to keep it for future use as well
romange
reviewed
Nov 5, 2023
src/server/test_utils.h
Outdated
| @@ -94,6 +94,9 @@ class BaseFamilyTest : public ::testing::Test { | |||
|
|
|||
| void ShutdownService(); | |||
|
|
|||
| void InitWithDbFilename(); | |||
| void DelSerializedFiles(); | |||
There was a problem hiding this comment.
nit: maybe rename it to CleanupSnapshots() ?
romange
previously approved these changes
Nov 5, 2023
romange
approved these changes
Nov 6, 2023
|
That would be a useful feature indeed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty recent regression.