Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acl): add acl keys to acl log command #2274

Merged
merged 9 commits into from
Dec 12, 2023
Merged

feat(acl): add acl keys to acl log command #2274

merged 9 commits into from
Dec 12, 2023

Conversation

kostasrim
Copy link
Contributor

PR7

  • add acl keys to acl log command
  • add tests

part of #2229

@kostasrim kostasrim self-assigned this Dec 7, 2023
@kostasrim kostasrim changed the base branch from main to aclkeys6 December 7, 2023 17:39
@kostasrim kostasrim requested a review from dranikpg December 7, 2023 17:40
@dranikpg
Copy link
Contributor

dranikpg commented Dec 7, 2023

please stop making so many PR's, I lose track of them 😆 You can push multiple commits into one PR and I can read them part by part, besides 30 changediff is not so much

Like we're on branch 7 now 🤯

@kostasrim
Copy link
Contributor Author

@dranikpg this is the last one 😛 I just didn't want to end up with 700+ changes like the bitops one :)

dranikpg
dranikpg previously approved these changes Dec 8, 2023
Base automatically changed from aclkeys6 to main December 8, 2023 16:08
@kostasrim kostasrim dismissed dranikpg’s stale review December 8, 2023 16:08

The base branch was changed.

@kostasrim kostasrim requested a review from dranikpg December 12, 2023 10:20
@kostasrim kostasrim merged commit 8640eda into main Dec 12, 2023
10 checks passed
@kostasrim kostasrim deleted the aclkeys7 branch December 12, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants