feat(server): implement JSON.TOGGLE & JSON.ARRLEN & JSON.OBJLEN commands #228
Conversation
src/server/json_family.cc
Outdated
| (*cntx)->StartArray(result->size()); | ||
| for (auto& it: *result) { | ||
| if (it.has_value()) { | ||
| (*cntx)->SendLong(*it); |
There was a problem hiding this comment.
@romange, Should I implement a function that retrieves a long long value, right?
There was a problem hiding this comment.
you mean like SendLong? Then no, because on 64bit architectures long long and long is the same and we are only 64bit.
src/server/json_family.cc
Outdated
| vector<OptLongLong> vec; | ||
| auto cb = [&](const string& path, json& val) { | ||
| if (val.is_number()) { | ||
| auto current_val = val.as<long long>() * num; |
There was a problem hiding this comment.
I should return an OVERFLOW error if the result is out of the range of 64-bit IEEE double.
There was a problem hiding this comment.
In order to provide fully compatible behavior, we need to setup an elasticache instance and learn how these special cases are handled there. That's out of scope of this assignment at this point.
what I usually do is I write // TODO: .... comments when the code needs further enhancement.
src/server/json_family.cc
Outdated
| return result.status(); | ||
| } | ||
|
|
||
| vector<OptLongLong> vec; |
There was a problem hiding this comment.
please add a comment TODO: to check how double and boolean are handled by INCRBY
|
Please see #240. I suggest that you copy
|
romange
changed the title
iko1
force-pushed
the
Json
branch
2 times, most recently
from
a02b27a to
55c96ea
Compare
This PR contains only the commands described in the title. Other JSON commands that were related to this PR will copy to another PR with a significant refactor(Thanks for the comments). |
iko1
force-pushed
the
Json
branch
2 times, most recently
from
37d8c60 to
1e23005
Compare
…nds (dragonflydb#241) Signed-off-by: iko1 <[email protected]>
| if (result->empty()) { | ||
| (*cntx)->SendNullArray(); | ||
| } else { | ||
| (*cntx)->StartArray(result->size()); |
There was a problem hiding this comment.
there are three repetitions of the same code of sending a long array.
We can factor them out in the next changes.
There was a problem hiding this comment.
I put it as a requirement for the next PR.
…nds (#228) feat(server): implement JSON.TOGGLE & JSON.ARRLEN & JSON.OBJLEN commands (#241) Signed-off-by: iko1 <[email protected]> Signed-off-by: iko1 <[email protected]>
…nds (#228) feat(server): implement JSON.TOGGLE & JSON.ARRLEN & JSON.OBJLEN commands (#241) Signed-off-by: iko1 <[email protected]> Signed-off-by: iko1 <[email protected]>
Signed-off-by: iko1 [email protected]
fixes: #241