bug(server): reject replicaof while loading from snapshot #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
chakaz
reviewed
Dec 27, 2023
src/server/server_family.cc
Outdated
Comment on lines
495
to
507
| const auto load_path_result = snapshot_storage_->LoadPath(flag_dir, GetFlag(FLAGS_dbfilename)); | ||
| if (load_path_result) { | ||
| const std::string load_path = *load_path_result; | ||
| if (!load_path.empty()) { | ||
| load_result_ = Load(load_path); | ||
| } | ||
| } else { | ||
| LOG(ERROR) << "Failed to load snapshot: " << load_path_result.error().Format(); | ||
| if (std::error_code(load_path_result.error()) == std::errc::no_such_file_or_directory) { | ||
| LOG(WARNING) << "Load snapshot: No snapshot found"; | ||
| } else { | ||
| LOG(ERROR) << "Failed to load snapshot: " << load_path_result.error().Format(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you wrap this in a function, so that Init() is simpler?
Signed-off-by: adi_holden <[email protected]>
chakaz
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2337
The bug:
replicaof was not rejected while loading snapshot
The fix:
replicaof is allowed while server is in loading state to allow replicaof while replication in full sync mode
I now reject replicaof if the server is in loading state and it is master
Another bug fix:
allow cron snapshot if --replicaof flag was set