feat(tiering): add max file size limit #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
adiholden
changed the title
romange
reviewed
Dec 27, 2023
src/server/engine_shard_set.cc
Outdated
| @@ -29,6 +33,11 @@ ABSL_FLAG(string, spill_file_prefix, "", | |||
| " associated with tiered storage. E.g," | |||
| "spill_file_prefix=/path/to/file-prefix"); | |||
|
|
|||
| ABSL_FLAG(dfly::MemoryBytesFlag, max_file_size, dfly::MemoryBytesFlag{}, | |||
There was a problem hiding this comment.
I suggest prefixing this flag with a feature name, aka tiered_file_max_size.
or spill_file_max_size for consistency though I think we won't use spill file externally so it probably not a good name,
romange
reviewed
Dec 27, 2023
src/server/engine_shard_set.cc
Outdated
| @@ -787,14 +797,52 @@ auto EngineShard::AnalyzeTxQueue() -> TxQueueInfo { | |||
|
|
|||
| */ | |||
|
|
|||
| uint64_t GetDiskLimit() { | |||
There was a problem hiding this comment.
GetDiskLimit -> GetFsLimit
romange
reviewed
Dec 27, 2023
romange
reviewed
Dec 28, 2023
src/server/engine_shard_set.cc
Outdated
| max_shard_file_size = max_file_size / shard_queue_.size(); | ||
| if (max_shard_file_size < 256_MB) { | ||
| LOG(ERROR) << "Max tiering file size is too small. Setting: " | ||
| << HumanReadableNumBytes(max_file_size) << " Requeried at least " |
Signed-off-by: adi_holden <[email protected]>
|
@romange ping |
romange
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2207