Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): implement json.numincrby (#240) #252

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

iko1
Copy link
Contributor

@iko1 iko1 commented Aug 23, 2022

resolves #240

Signed-off-by: iko1 [email protected]

src/server/json_family.cc Outdated Show resolved Hide resolved
src/server/json_family.cc Outdated Show resolved Hide resolved
src/server/json_family_test.cc Outdated Show resolved Hide resolved
@iko1 iko1 marked this pull request as ready for review August 26, 2022 08:45
@iko1 iko1 requested a review from romange August 26, 2022 08:46
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good, just a few questions...

src/server/json_family.cc Show resolved Hide resolved
src/server/json_family.cc Show resolved Hide resolved
src/server/json_family.cc Show resolved Hide resolved
src/server/json_family.cc Show resolved Hide resolved
src/server/json_family.cc Show resolved Hide resolved
src/server/json_family_test.cc Outdated Show resolved Hide resolved
@iko1 iko1 requested a review from romange August 26, 2022 12:45
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please do not start working on the next task yet, I want to rebase the branch over "main"

@romange romange merged commit fd43762 into dragonflydb:Json Aug 26, 2022
romange pushed a commit that referenced this pull request Aug 26, 2022
* feat(server): implement json.numincrby (#240)

Signed-off-by: iko1 <[email protected]>
romange pushed a commit that referenced this pull request Aug 26, 2022
* feat(server): implement json.numincrby (#240)

Signed-off-by: iko1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants