Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add emoji when regression tests timeout #2543

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix: add emoji when regression tests timeout #2543

merged 3 commits into from
Feb 5, 2024

Conversation

kostasrim
Copy link
Contributor

I had a very good reason why I did not use the: https://pypi.org/project/pytest-timeout/ when I added timeouts. I quote

  1. While by default on POSIX systems pytest will continue to execute the tests after a test has timed out this is not always possible.
  2. pytest --timeout=300 only works for individual tests and not the whole session.

That was the very reason I opted in for timeout shell command

There is a simpler solution to warn against timeouts. Since we can use any emoji, we can have one dedicated for timeouts and scream that by printing it. This will come up at the end (next to the error message) so you can be aware that the tests timedout.

@kostasrim kostasrim changed the title Ci timeouts fix: add emoji when regression tests timeout Feb 5, 2024
@kostasrim kostasrim self-assigned this Feb 5, 2024
@kostasrim
Copy link
Contributor Author

@kostasrim kostasrim merged commit f707f6d into main Feb 5, 2024
10 checks passed
@kostasrim kostasrim deleted the ci_timeouts branch February 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants