Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pytest): Gen2 seeder, part 1 #2556

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Feb 6, 2024

Adds new seeder based on lua scripts and a python wrapper for working with them

For now, doesn't support operations with types other than strings and only single-key operations

Intensity balance:

image
key target - 300
blue - add intensity
green - delete intensity
red - modification intensity
equilibrium point = ~0.956 * T

@dranikpg dranikpg changed the title feat(pytest): Gen2 seeder feat(pytest): Gen2 seeder, part 1 Feb 6, 2024
@dranikpg dranikpg force-pushed the new-seeder-base branch 2 times, most recently from ef759f8 to 56d6e13 Compare February 7, 2024 11:44
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
@dranikpg dranikpg marked this pull request as ready for review February 7, 2024 13:22
@dranikpg dranikpg requested a review from chakaz February 7, 2024 13:23
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pretend to understand all the Lua logic 🤣

replicate(master, replica)

# Ensure master and replica have same state hashes
master_hashes, replica_hashes = asyncio.gather(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we missing await in this statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, we are, will add in next PR

@dranikpg dranikpg merged commit 881edb5 into dragonflydb:main Feb 9, 2024
7 checks passed
@dranikpg dranikpg deleted the new-seeder-base branch February 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants