Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull helio #3350

Merged
merged 2 commits into from
Jul 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/server/engine_shard_set.cc
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,8 @@ void EngineShard::RunPeriodic(std::chrono::milliseconds period_ms) {

// Every 8 runs, update the global stats.
if (global_count % 8 == 0) {
DVLOG(2) << "Global periodic";

uint64_t sum = 0;
const auto& stats = EngineShardSet::GetCachedStats();
for (const auto& s : stats)
Expand Down
5 changes: 3 additions & 2 deletions src/server/tiered_storage_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,10 @@ TEST_F(TieredStorageTest, BackgroundOffloading) {

// Wait for offload to do it all again
ExpectConditionWithinTimeout([&] { return GetMetrics().db_stats[0].tiered_entries == kNum; });

auto resp = Run({"INFO", "ALL"});
LOG(INFO) << "INFO " << resp.GetString();
auto metrics = GetMetrics();
EXPECT_EQ(metrics.tiered_stats.total_stashes, 2 * kNum);
EXPECT_EQ(metrics.tiered_stats.total_stashes, 2 * kNum) << resp.GetString();
EXPECT_EQ(metrics.tiered_stats.total_fetches, kNum);
EXPECT_EQ(metrics.tiered_stats.allocated_bytes, kNum * 4096);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/dragonfly/connection_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ async def test_parser_memory_stats(df_server, async_client: aioredis.Redis):
await writer.drain()
# writer is pending because the request is not finished.
stats = await async_client.execute_command("memory stats")
assert stats["connections.direct_bytes"] > 150000
assert stats["connections.direct_bytes"] > 130000


async def test_reject_non_tls_connections_on_tls(with_tls_server_args, df_factory):
Expand Down
Loading