Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failure in test_cluster_fuzzymigration #3363

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: failure in test_cluster_fuzzymigration #3363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/dragonfly/cluster_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,6 @@ async def test_network_disconnect_during_migration(df_factory, df_seeder_factory
await close_clients(*[node.client for node in nodes], *[node.admin_client for node in nodes])


@pytest.mark.skip("Fails in CI, TODO: to reenable it")
@pytest.mark.parametrize(
"node_count, segments, keys",
[
Expand Down Expand Up @@ -1373,7 +1372,6 @@ async def list_counter(key, client: aioredis.RedisCluster):

logging.debug("finish migrations")

@assert_eventually(times=500)
async def all_finished():
res = True
for node in nodes:
Expand Down Expand Up @@ -1410,7 +1408,11 @@ async def all_finished():
res = False
return res

await all_finished
@assert_eventually(times=500)
async def test_all_finished():
assert await all_finished()

await test_all_finished()

for counter in counters:
counter.cancel()
Expand Down
Loading