Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pytest warnings #3497

Merged
merged 6 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/regression-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ runs:

# timeout returns 124 if we exceeded the timeout duration
if [[ $code -eq 124 ]]; then
# Add an extra new line here because when tests timeout the first line below continues from the test failure name
echo "\n"
echo "🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑"
echo "🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 TESTS TIMEDOUT 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑"
echo "🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑 🛑"
Expand Down
1 change: 0 additions & 1 deletion tests/dragonfly/pymemcached_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def test_basic(memcached_client: MCClient):
# Noreply (and pipeline) tests


@pytest.mark.dbg_only
@dfly_args(DEFAULT_ARGS)
def test_noreply_pipeline(df_server: DflyInstance, memcached_client: MCClient):
"""
Expand Down
6 changes: 3 additions & 3 deletions tests/dragonfly/snapshot_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import os
import glob
import asyncio
import async_timeout
from async_timeout import timeout
import redis
from redis import asyncio as aioredis
from pathlib import Path
Expand Down Expand Up @@ -169,7 +169,7 @@ async def test_cron_snapshot(tmp_dir: Path, async_client: aioredis.Redis):
await StaticSeeder(**LIGHTWEIGHT_SEEDER_ARGS).run(async_client)

file = None
with async_timeout.timeout(65):
async with timeout(65):
while file is None:
await asyncio.sleep(1)
file = find_main_file(tmp_dir, "test-cron-summary.dfs")
Expand All @@ -185,7 +185,7 @@ async def test_set_cron_snapshot(tmp_dir: Path, async_client: aioredis.Redis):
await async_client.config_set("snapshot_cron", "* * * * *")

file = None
with async_timeout.timeout(65):
async with timeout(65):
while file is None:
await asyncio.sleep(1)
file = find_main_file(tmp_dir, "test-cron-set-summary.dfs")
Expand Down
Loading