Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tune test_replicaof_reject_on_load parameters #3762

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: tune test_replicaof_reject_on_load parameters #3762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/dragonfly/replication_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,7 +2014,7 @@ async def test_replicaof_reject_on_load(df_factory, df_seeder_factory):
df_factory.start_all([master, replica])

c_replica = replica.client()
await c_replica.execute_command(f"DEBUG POPULATE 10000000")
await c_replica.execute_command(f"DEBUG POPULATE 8000000")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very slow test, takes lots of time. Borys should be working on fixing it (not by tuning the params)
hope to see a PR soon

Copy link
Contributor

@BorysTheDev BorysTheDev Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't have the idea how to improve it without adding some debug commands and additional info

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is not worth spending time on. Lets merge and move on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mark this as a slow test and you can also add shutdown no save when stopping the replica to reduce the test time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it was marked as automerge


replica.stop()
replica.start()
Expand All @@ -2031,8 +2031,9 @@ async def test_replicaof_reject_on_load(df_factory, df_seeder_factory):
assert False
except aioredis.BusyLoadingError as e:
assert "Dragonfly is loading the dataset in memory" in str(e)

# Check one we finish loading snapshot replicaof success
await wait_available_async(c_replica)
await wait_available_async(c_replica, timeout=180)
await c_replica.execute_command(f"REPLICAOF localhost {master.port}")

await c_replica.close()
Expand Down
Loading