chore(fakeredis): Enable JSON tests in the Fakeredis tests #3773
Conversation
BagritsevichStepan
force-pushed
the
json/enable_json_fakeredis_tests
branch
from
927b591 to
184f3ce
Compare
|
Can you please add a unit test for |
|
Good work! |
BagritsevichStepan
force-pushed
the
json/enable_json_fakeredis_tests
branch
from
6991832 to
8a7d31c
Compare
BagritsevichStepan
requested review from
romange
and removed request for
romange
|
Due to the fact that for The problem is mentioned in the #3777 issue. When it will be fixed, we will be able to check the error message in the tests. |
| } | ||
| } | ||
|
|
||
| std::optional<JsonPathType> path_type; |
There was a problem hiding this comment.
I see that all this values has const default values
kDefaultOnEmpty
and kDefaultJsonPathType
so why do we need to use std::optional?
| std::optional<JsonPathType> path_type = std::nullopt; | ||
| SavingOrder saving_order{SavingOrder::kSaveLast}; | ||
| OnEmpty on_empty{OnEmpty::kSendWrongType}; | ||
| void InitializeEmptyOptions(JsonPathType default_path_type, OnEmpty default_on_empty) { |
There was a problem hiding this comment.
I find this confusing
calling this function will initialize the values if they are not already initialized?
So do we have flows when we call this function twice with different values and only the first call should set the values?
fixes dragonflydb#3671 Signed-off-by: Stsiapan Bahrytsevich <[email protected]>
Signed-off-by: Stsiapan Bahrytsevich <[email protected]>
Signed-off-by: Stsiapan Bahrytsevich <[email protected]>
Signed-off-by: Stsiapan Bahrytsevich <[email protected]>
BagritsevichStepan
force-pushed
the
json/enable_json_fakeredis_tests
branch
from
8a7d31c to
ea6a3db
Compare
fixes #3671
JSON.ARRINDEXcommand. It should return error for the empty result in the legacy modetest_json_arr_commands.py::test_arrindex