chore: refactor XRead #3775
Merged
chore: refactor XRead #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
|
I'll add single shard optimizations separately to keep the PR smaller (I predict complains about the size 😝) |
romange
reviewed
Sep 27, 2024
| @@ -1342,6 +1312,12 @@ OpStatus OpDestroyGroup(const OpArgs& op_args, string_view key, string_view gnam | |||
| if (cgr_res->cg) { | |||
| raxRemove(cgr_res->s->cgroups, (uint8_t*)(gname.data()), gname.size(), NULL); | |||
| streamFreeCG(cgr_res->cg); | |||
|
|
|||
There was a problem hiding this comment.
add comment that you awake readers that are blocked on a consumer from this cg
romange
previously approved these changes
Sep 27, 2024
romange
approved these changes
Sep 27, 2024
romange
pushed a commit
that referenced
this pull request
Sep 30, 2024
Previously XREAD: - Fetched group consumer info (with a hop) - Looked up last stream ids (with a hop) - Determined if there are entries to read (on coordinator) - Dispatched a hop to read entries or retired to blocking mode Instead we can merge steps (1), (2) and (3) into a single step, optionally with step (4) for single shard operations that can avoid concluding (we had this optimization before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3770
Previously XREAD:
Instead we can merge steps (1), (2) and (3) into a single step, optionally with step (4) for single shard operations that can avoid concluding (we had this optimization before)