chore(acl_family): add allcomands and nocommands #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
added
hacktoberfest
kostasrim
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Hi @Lakshyadevelops,
Thank you so much for your contribution! Would you mind also adding a unit test ?
I also left a very small nit :)
src/server/acl/acl_family.cc
Outdated
| @@ -990,6 +990,22 @@ using OptCat = std::optional<uint32_t>; | |||
| // bool == true if + | |||
| // bool == false if - | |||
| std::pair<OptCat, bool> AclFamily::MaybeParseAclCategory(std::string_view command) const { | |||
| if (absl::EqualsIgnoreCase(command, "ALLCOMMANDS")) { | |||
| auto res = cat_table_.find("ALL"); | |||
There was a problem hiding this comment.
ALL will always exist in cat_table_ so you don't really need to call find and compare that cat_table_.end().
You can just use cat_table_["ALL"] :)
There was a problem hiding this comment.
Yeah, you are right about comparing to cat_table_.end()
I tried to used operator[] but it was failing due to type mismatch and even after casting to std::string_view it was failing due to -fpermissive (this arguement discards qualifier) so finally used .at()
Lakshyadevelops
force-pushed
the
allcommands
branch
from
825d6a4 to
d0e3bf7
Compare
kostasrim
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3458
TESTED =
I did not add tests as there was no test earlier for the same but it can be added.