chore: ScheduleInternal refactoring #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small refactoring to improve the flow of ScheduleInternal() as well as to prepare it for the next change that will reduce the CPU load from the shard queue. Signed-off-by: Roman Gershman <[email protected]>
romange
commented
Sep 25, 2024
| run_barrier_.Start(unique_shard_cnt_); | ||
|
|
There was a problem hiding this comment.
there are no functional changes in this code
romange
commented
Sep 25, 2024
| } | ||
|
|
||
| if (schedule_fails.load(memory_order_relaxed) == 0) { |
There was a problem hiding this comment.
if we go into CanRunInlined branch then schedule_fails is 0. In fact schedule_fails check is only relevant for the else branch (IterateActiveShards)
There was a problem hiding this comment.
True, good simplification
romange
commented
Sep 25, 2024
| @@ -762,6 +775,9 @@ void Transaction::ScheduleInternal() { | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| coordinator_state_ |= COORD_SCHED; | |||
There was a problem hiding this comment.
final phase: we succeeded scheduling - update the stats
dranikpg
approved these changes
Sep 25, 2024
| } | ||
|
|
||
| if (schedule_fails.load(memory_order_relaxed) == 0) { |
There was a problem hiding this comment.
True, good simplification
Comment on lines
+727
to
+735
| ScheduleContext schedule_ctx{this, can_run_immediately}; | ||
|
|
||
| auto cb = [&schedule_ctx]() { | ||
| if (!schedule_ctx.trans->ScheduleInShard(EngineShard::tlocal(), | ||
| schedule_ctx.optimistic_execution)) { | ||
| schedule_ctx.fail_cnt.fetch_add(1, memory_order_relaxed); | ||
| } | ||
| schedule_ctx.trans->FinishHop(); | ||
| }; |
There was a problem hiding this comment.
- You forgot a rename in the last pr: can_run_immediately 🙂
- What's the raison d'être of ScheduleContext? 🤓 You don't pass it around, so it's not code simplicifaction. Is it to reduce the functor size by capturing a single pointer?
There was a problem hiding this comment.
- Will do.
- You will see it in the next PR (if it works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactoring to improve the flow of ScheduleInternal() as well as to prepare it for the next change that will reduce the CPU load from the shard queue.