fix: empty strings and Nan in the sort command #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
previously approved these changes
Sep 27, 2024
BorysTheDev
changed the title
kostasrim
reviewed
Sep 27, 2024
BorysTheDev
force-pushed
the
fix_empty_strings_in_sort
branch
from
8c1e2f7 to
7429c77
Compare
BorysTheDev
changed the title
BorysTheDev
changed the title
kostasrim
reviewed
Sep 27, 2024
kostasrim
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
RPUSH key 0 -1 2 '' 32 nan
SORT key
The result is an error because of ''
Expected result: -1 '' 0 2 32
We didn't process empty strings for number sorting
Also prohibit Nan for number sorting