chore: reformat listpack according to valkey 8 #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add benchmarks for lpCompare code when list contains integers. Signed-off-by: Roman Gershman <[email protected]>
romange
changed the title
kostasrim
approved these changes
Sep 27, 2024
| @@ -787,12 +773,12 @@ unsigned char *lpInsert(unsigned char *lp, const unsigned char *elestr, unsigned | |||
| unsigned char backlen[LP_MAX_BACKLEN_SIZE]; | |||
|
|
|||
| uint64_t enclen; /* The length of the encoded element. */ | |||
| int delete = (elestr == NULL && eleint == NULL); | |||
| int del_ele = (elestr == NULL && eleint == NULL); | |||
Comment on lines
+736
to
+740
| std::random_device rd; | ||
| uint8_t* lp = lpNew(0); | ||
| for (unsigned i = 0; i < 100; ++i) { | ||
| lp = lpAppendInteger(lp, rd() % (1ULL << 48)); | ||
| } |
There was a problem hiding this comment.
I was about to comment that is used below but IMO it's just a test and only a few lines so who cares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add benchmarks for lpCompare code when list contains integers.
No functional changes.