chore: singlehop XREAD #3817
Merged
chore: singlehop XREAD #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
fast-xread
branch
from
cc65dc7 to
971718e
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
reviewed
Sep 28, 2024
| @@ -2948,21 +2948,33 @@ void XReadGeneric2(CmdArgList args, ConnectionContext* cntx, bool read_group) { | |||
|
|
|||
| auto* tx = cntx->transaction; | |||
|
|
|||
| // Determine if streams have entries | |||
| // Determine if streams have entries or any error occured | |||
| AggregateValue<optional<facade::ErrorReply>> err; | |||
| atomic_bool have_entries = false; | |||
There was a problem hiding this comment.
why atomic_bool? hops ensure sequential memory order in the coordinator so seems can be done with a regular bool?
There was a problem hiding this comment.
Concurrently writes? 🙂
romange
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring broke single shard single hop xread, here it is again