chore: WrapSds from family_utils.h #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Sep 28, 2024
| if (blocking_controller) { | ||
| blocking_controller->AwakeWatched(op_args.db_cntx.db_index, key); | ||
| } | ||
| raxRemove(cgr_res->s->cgroups, (uint8_t*)(gname.data()), gname.size(), NULL); |
There was a problem hiding this comment.
ping here? Did you validate that based on the code cgr_res->cg is always defined here?
Please add DCHECK before raxRemove
romange
reviewed
Oct 1, 2024
| consumer = streamCreateConsumer(cgr_res->cg, op_args.shard->tmp_str1, nullptr, 0, | ||
| SCC_NO_NOTIFY | SCC_NO_DIRTIFY); | ||
| auto cname = WrapSds(opts.consumer); | ||
| if ((consumer = streamLookupConsumer(cgr_res->cg, cname, SLC_NO_REFRESH)) == nullptr) { |
There was a problem hiding this comment.
nit: i personally do not like these double level expressions.
There was a problem hiding this comment.
Not me who introduced it ☝🏻
kostasrim
reviewed
Oct 1, 2024
Co-authored-by: Kostas Kyrimis <[email protected]> Signed-off-by: Roman Gershman <[email protected]>
kostasrim
reviewed
Oct 1, 2024
Signed-off-by: Kostas Kyrimis <[email protected]>
kostasrim
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some of the c'stlye code