feat(search): STOPWORDS #3851
feat(search): STOPWORDS #3851
Conversation
dranikpg
force-pushed
the
search-stopword-1
branch
2 times, most recently
from
b5a7db7 to
ada95d0
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
search-stopword-1
branch
from
ada95d0 to
468b98f
Compare
src/core/search/search.h
Outdated
| const Schema* schema_; | ||
| const IndicesOptions* options_; |
There was a problem hiding this comment.
Same shared_ptr vs ptr question here. Everything points esentially to shared_ptr that is created in the coordinator when parsing the index definition. Lifetimes are ensured by ShardDocIndex that create the FieldIndices
There was a problem hiding this comment.
if you feel that shared_ptr is more correct because of lack of single owner, then lets switch to shared_ptr
| bool was_built_ = false; | ||
| std::shared_ptr<const DocIndex> base_; | ||
| search::FieldIndices indices_; | ||
| std::optional<search::FieldIndices> indices_; |
There was a problem hiding this comment.
More elegant, creating a dummy instance with nullptrs was just an ugly hack
| private: | ||
| const StopWords* stopwords_; |
There was a problem hiding this comment.
- Not sure if to make it a shared_ptr (can be easily created from IndexOptions from an aliasing constructor)
- Const-ptr to indicate longevity... or use a reference instead?
There was a problem hiding this comment.
Ah I forgot to make this a constref 😨 Never mind
src/core/search/search.cc
Outdated
| IndicesOptions::IndicesOptions() { | ||
| static absl::flat_hash_set<std::string> kDefaultStopwords{ | ||
| "a", "is", "the", "an", "and", "are", "as", "at", "be", "but", "by", | ||
| "for", "if", "in", "into", "it", "no", "not", "of", "on", "or", "such", | ||
| "that", "their", "then", "there", "these", "they", "this", "to", "was", "will", "with"}; | ||
|
|
||
| stopwords_ = kDefaultStopwords; | ||
| } |
There was a problem hiding this comment.
Not sure if this should be part of the core module or the server module 🤔
|
Remebered: Need to add and test persistence 🤓 |
src/core/search/search.cc
Outdated
| stopwords_ = kDefaultStopwords; | ||
| } | ||
|
|
||
| FieldIndices::FieldIndices(const Schema* schema, const IndicesOptions* options, |
There was a problem hiding this comment.
if the ownership stays with the caller while this object lives, it's better using const refs
dranikpg
force-pushed
the
search-stopword-1
branch
from
dd4344e to
5f95cf6
Compare
Support for FT.STOPWORDS